Make dry_run a setting and --force its inverse #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
added a commit
to mdellweg/pulp-cli
that referenced
this pull request
May 12, 2021
mdellweg
force-pushed
the
no_dry_run
branch
3 times, most recently
from
fe73eba
to
44c2859
Compare
daviddavis
approved these changes
May 13, 2021
There was a problem hiding this comment.
LGTM. Maybe update https://github.com/pulp/pulp-cli/blob/develop/docs/install.md#katello ?
mdellweg
commented
May 13, 2021
| @@ -87,3 +87,6 @@ key = "/etc/pki/katello/private/pulp-client.key" | |||
| verify_ssl = false | |||
| ``` | |||
|
|
|||
| As Katello uses Pulp as a backend all modifying actions in Pulp should be performed via Katello. | |||
| Therefore you are also strongly encourged to set `dry_run = false`, to prevent accidentally calling into dangerous commands. | |||
| This setting can in turn be overwritten on the command-line with the `--force` flag. | |||
There was a problem hiding this comment.
@daviddavis
Is this, what you had in mind?
Merged
daviddavis
approved these changes
May 13, 2021
evgeni
reviewed
May 18, 2021
| @@ -87,3 +87,6 @@ key = "/etc/pki/katello/private/pulp-client.key" | |||
| verify_ssl = false | |||
| ``` | |||
|
|
|||
| As Katello uses Pulp as a backend all modifying actions in Pulp should be performed via Katello. | |||
| Therefore you are also strongly encourged to set `dry_run = false`, to prevent accidentally calling into dangerous commands. | |||
There was a problem hiding this comment.
Should that have been dry_run = true? ;-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes TBA