Generic object roles subcommand group #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdellweg
force-pushed
the
object_roles
branch
5 times, most recently
from
fbf09fd
to
eff5f7e
Compare
mdellweg
changed the title
gerrod3
reviewed
Dec 15, 2021
pulpcore/cli/core/content_guard.py
Outdated
| @@ -51,6 +52,7 @@ def rbac(ctx: click.Context, pulp_ctx: PulpContext) -> None: | |||
| rbac.add_command(show_command(decorators=lookup_options)) | |||
| rbac.add_command(update_command(decorators=lookup_options)) | |||
| rbac.add_command(destroy_command(decorators=lookup_options)) | |||
| rbac.add_command(role_command(decorators=lookup_options)) | |||
There was a problem hiding this comment.
Shouldn't each object adding the role command have needs_plugin=[PluginRequirement("core", min="3.17.0.dev")]
There was a problem hiding this comment.
That's a good observation.
mdellweg
force-pushed
the
object_roles
branch
2 times, most recently
from
7b6dde4
to
e598d57
Compare
* Provide the role_command generic. * Added to tasks, groups and RBAC content guards. [noissue]
mdellweg
force-pushed
the
object_roles
branch
from
e598d57
to
115c0de
Compare
|
@gerrod should be ready now. |
Cool! But wrong guy, I don't know what a pulp is. |
gerrod3
approved these changes
Dec 16, 2021
| allowed_with_contexts: Optional[Tuple[Type[PulpEntityContext]]] = None, | ||
| **kwargs: Any, | ||
| ): | ||
| self.needs_plugins = needs_plugins |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.