1124570 - Adds two-queue implementation for reserved resources #1158
Conversation
| @@ -80,7 +76,6 @@ def setUpClass(cls): | |||
| def tearDownClass(cls): | |||
| name = pulp_conf.get('database', 'name') | |||
| connection._CONNECTION.drop_database(name) | |||
| cls.reserve_resources_patch.stop() | |||
There was a problem hiding this comment.
It's a race to see who merges first, because I bet one of my PRs will cause a conflict with this ☺
There was a problem hiding this comment.
Turns out it does conflict!
There was a problem hiding this comment.
Maybe I should slow down my review time to increase the chance that someone else reviews my PR first. This is a conflict of interest. Get it? Get it‽
| @@ -2,10 +2,8 @@ | |||
| This module contains management functions for the models found in the | |||
There was a problem hiding this comment.
I need to finish reviewing this tomorrow. This comment is here to mark how far I got during review ☺
|
|
||
| def test__delete_worker_Criteria_to_find_TaskStatus_is_correct(self): |
There was a problem hiding this comment.
s/TaskStatus/task_status/
|
LGTM if you can make sure that the tests do pass on all platforms. |
|
Oh, and make sure that we do set the tags on both insert and update ☺ |
|
When you merge this, please also mark this bug as MODIFIED: https://bugzilla.redhat.com/show_bug.cgi?id=1141336 |
|
I fixed the unit test failure on CentOS 6 which was due to a different behavior between mock 0.8 and 1.0. CentOS provides mock 0.8. I've adjusted the test to work in both environments, and reran it on EL6, so it's passing |
|
Lots of fixes introduced with 33ba0e0 |
|
Merging! Thanks to @rbarlow for all the great review and help with this. RabbitMQ should work now. :-) |
1124570 - Adds two-queue implementation for reserved resources
…ckages Add --force-full flag to publish command re pulp#1158 https://pulp.plan.io/issues/1158 (cherry picked from commit 2f4389a)
BZ #1223023 - Allow Pulp to force sync and verify/repair corrupted packages Add --force-full flag to publish command re pulp#1158 https://pulp.plan.io/issues/1158 (cherry picked from commit 2f4389a) See merge request !28
https://bugzilla.redhat.com/show_bug.cgi?id=1124570
This BZ implements this design and TODO list. Refer to that doc for more info on what is contained in this PR.