Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
/ pulp Public archive

Add install_requires arguments to our setup.py files. #1662

Merged
merged 1 commit into from
Feb 24, 2015

Conversation

bowlofeggs
Copy link
Contributor

This commit also removes some incorrect Requires lines in our spec file, and adds
python-gofer-qpid to our server qpid group.

https://pulp.plan.io/issues/278

re #278

This is necessary to satisfy Travis in pulp/pulp_python#20

@pulpbot
Copy link
Member

pulpbot commented Feb 19, 2015

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/258/
Test PASSed.

@pulpbot
Copy link
Member

pulpbot commented Feb 19, 2015

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/259/
Test PASSed.

This commit also removes some incorrect Requires lines in our spec file, and adds
python-gofer-qpid to our server qpid group.

https://pulp.plan.io/issues/278

re pulp#278
@bowlofeggs
Copy link
Contributor Author

I can confirm that the current state of this PR did pass a test Travis build on the Python plugins.

@pulpbot
Copy link
Member

pulpbot commented Feb 19, 2015

Refer to this link for build results (access rights to CI server needed):
https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com//job/unittest-pulp-pr/260/
Test PASSed.

Requires: python-oauth2 >= 1.5.211
Requires: python-httplib2
Requires: python-isodate >= 0.5.0-1.pulp
Requires: python-BeautifulSoup
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wondered why that was in there.

@asmacdo
Copy link
Contributor

asmacdo commented Feb 20, 2015

LGTM, but I think someone with more experience with builds should also take a look.

@beav
Copy link
Contributor

beav commented Feb 24, 2015

this LGTM as well, after rebasing

@bowlofeggs bowlofeggs merged commit 31201f7 into pulp:2.6-dev Feb 24, 2015
@bowlofeggs bowlofeggs deleted the 278 branch February 24, 2015 19:06
@bowlofeggs
Copy link
Contributor Author

On 02/24/2015 11:43 AM, Chris Duryee wrote:

this LGTM as well

Thanks for the review! I updated the Python pull request to use only
Pulp master now. Hopefully Travis will think everything is cool now.

bowlofeggs pushed a commit to bowlofeggs/pulp that referenced this pull request Feb 15, 2016
pulp.server.managers.repo.unit_association.RepoUnitAssociationManager._units_from_criteria()
was not passing the criteria's unit_fields list along to the next
callee. This caused significant memory usage in certian Pulp
operations. This commit corrects that oversight.

https://pulp.plan.io/issues/1662

fixes pulp#1662
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants