-
Notifications
You must be signed in to change notification settings - Fork 168
Add install_requires arguments to our setup.py files. #1662
Conversation
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
This commit also removes some incorrect Requires lines in our spec file, and adds python-gofer-qpid to our server qpid group. https://pulp.plan.io/issues/278 re pulp#278
I can confirm that the current state of this PR did pass a test Travis build on the Python plugins. |
Refer to this link for build results (access rights to CI server needed): |
Requires: python-oauth2 >= 1.5.211 | ||
Requires: python-httplib2 | ||
Requires: python-isodate >= 0.5.0-1.pulp | ||
Requires: python-BeautifulSoup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wondered why that was in there.
LGTM, but I think someone with more experience with builds should also take a look. |
this LGTM as well, after rebasing |
On 02/24/2015 11:43 AM, Chris Duryee wrote:
Thanks for the review! I updated the Python pull request to use only |
pulp.server.managers.repo.unit_association.RepoUnitAssociationManager._units_from_criteria() was not passing the criteria's unit_fields list along to the next callee. This caused significant memory usage in certian Pulp operations. This commit corrects that oversight. https://pulp.plan.io/issues/1662 fixes pulp#1662
This commit also removes some incorrect Requires lines in our spec file, and adds
python-gofer-qpid to our server qpid group.
https://pulp.plan.io/issues/278
re #278
This is necessary to satisfy Travis in pulp/pulp_python#20