django conversion - repo_groups urls #1670
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
| return generate_json_response_with_pulp_encoder(groups) | ||
|
|
||
| @auth_required(authorization.CREATE) | ||
| @json_body_allow_empty |
There was a problem hiding this comment.
I think in this case it should require the body, since for repo group creation you need at least the 'id' which is the required key
There was a problem hiding this comment.
Same as #1670 (comment).
| :param distributor_id: distributor to get | ||
| :type distributor_id: str | ||
|
|
||
| :return: response containing a serialized dict of the added distributor |
There was a problem hiding this comment.
response containing a serialized dict of requested distributor
asmacdo
force-pushed
the
django-repo-groups
branch
from
5e66624
to
c0d5bee
Compare
|
Refer to this link for build results (access rights to CI server needed): |
asmacdo
force-pushed
the
django-repo-groups
branch
from
c0d5bee
to
be59e8f
Compare
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 7 lines...]Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1670/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1670/merge^{commit} # timeout=10Checking out Revision c066f5e92510852331b14306658c363046defbae (refs/remotes/origin/pr/1670/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f c066f5e92510852331b14306658c363046defbaeFirst time build. Skipping changelog.Triggering rhel7-npTriggering f21-npTriggering rhel6-npTriggering rhel5-npTriggering f20-nprhel7-np completed with result FAILUREf21-np completed with result FAILURErhel6-np completed with result FAILURErhel5-np completed with result SUCCESSf20-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 1 secondSetting status of be59e8f to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/285/ and message: Merged build finished.Test FAILed. |
asmacdo
force-pushed
the
django-repo-groups
branch
from
be59e8f
to
73a040c
Compare
|
Refer to this link for build results (access rights to CI server needed): Build result: FAILURE[...truncated 7 lines...]Fetching upstream changes from https://github.com/pulp/pulp.git > git --version # timeout=10 > git fetch --tags --progress https://github.com/pulp/pulp.git +refs/pull/:refs/remotes/origin/pr/ > git rev-parse refs/remotes/origin/pr/1670/merge^{commit} # timeout=10 > git rev-parse refs/remotes/origin/origin/pr/1670/merge^{commit} # timeout=10Checking out Revision 57e0408 (refs/remotes/origin/pr/1670/merge) > git config core.sparsecheckout # timeout=10 > git checkout -f 57e0408f08ff274c09c9682bce5072ebe1315491First time build. Skipping changelog.Triggering rhel7-npTriggering f21-npTriggering rhel6-npTriggering rhel5-npTriggering f20-nprhel7-np completed with result FAILUREf21-np completed with result FAILURErhel6-np completed with result FAILURErhel5-np completed with result SUCCESSf20-np completed with result FAILUREStarted calculate disk usage of buildFinished Calculation of disk usage of build in 0 secondsStarted calculate disk usage of workspaceFinished Calculation of disk usage of workspace in 1 secondSetting status of 73a040c to FAILURE with url https://pulp-jenkins.rhev-ci-vms.eng.rdu2.redhat.com/job/unittest-pulp-pr/286/ and message: Merged build finished.Test FAILed. |
| cursor = collection.find({}) | ||
| groups = [] | ||
| for group in cursor: | ||
| group['_href'] = reverse('repo_group_resource', kwargs={'repo_group_id': group['id']}) |
There was a problem hiding this comment.
by the way, since reverse of 'repo_group_resource' is repeated 4 times you can do something like here c30f096#diff-113ebb31dc6faa5d855700dc67532dddR162
same with 'repo_group_distributor_resource'
There was a problem hiding this comment.
Makes sense but it is replacing a one line call that is unlikely to change. I would prefer to leave as since it will be more transparent.
asmacdo
force-pushed
the
django-repo-groups
branch
from
73a040c
to
941c6e5
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
LGTM. well done! |
asmacdo
force-pushed
the
django-repo-groups
branch
from
941c6e5
to
990e6fd
Compare
|
Refer to this link for build results (access rights to CI server needed): |
django conversion - repo_groups urls
Convert repo groups urls.
Hand testing, all identical where expected:
Includes a fix for BZ-1194421
GET /v2/repo_groups/http://fpaste.org/185364/38587891/
POST /v2/repo_groups/valid: http://fpaste.org/185372/59647142/
dupe: http://fpaste.org/185376/59826142/
invalid: http://fpaste.org/185377/85992414/
GET /v2/repo_groups/<repo_group_id>/valid: http://fpaste.org/185379/86021314/
invalid: http://fpaste.org/185381/38602891/
DELETE /v2/repo_groups/<repo_group_id>/valid: http://fpaste.org/185383/60646142/
invalid: http://fpaste.org/185386/23860786/
PUT /v2/repo_groups/<repo_group_id>/valid id: http://fpaste.org/185390/38613831/
invalid id: http://fpaste.org/185392/23861529/
invalid params: http://fpaste.org/185393/61678142/
POST /v2/repo_groups/<repo_group_id>/actions/associate/http://fpaste.org/185407/38634491/
POST /v2/repo_groups/<repo_group_id>/actions/unassociate/http://fpaste.org/185409/42386356/
Test function
http://fpaste.org/185406/23863285/
GET /v2/repo_grous/<repo_group_id>/distributors/This one includes a bugfix for BZ-1194421:
http://fpaste.org/188365/63810142/
POST /v2/repo_grous/<repo_group_id>/distributors/http://fpaste.org/187792/43762811/
GET /v2/repo_grous/<repo_group_id>/distributors/<distributor_id>/http://fpaste.org/187798/76869142/
GET /v2/repo_grous/<repo_group_id>/distributors/<distributor_id>/with fake idhttp://fpaste.org/187802/14243770/
PUT /v2/repo_grous/<repo_group_id>/distributors/<distributor_id>/Valid: http://fpaste.org/187820/14243794/
Invalid body: http://fpaste.org/187848/38209114/
Invalid repo group id or dist id: http://fpaste.org/188373/64561142/
DELETE /v2/repo_grous/<repo_group_id>/distributors/<distributor_id>/http://fpaste.org/188224/44922014/
POST /v2/repo_groups/<repo_group_id>/actions/publish/http://fpaste.org/188339/44601801/