This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
ref #1195 - Implement the pulp-streamer. #2065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremycline
force-pushed
the
task-1195
branch
from
c25b149
to
890a04e
Compare
|
This is very bare-bones right now since the things left to do depend on the incoming URL format which is not clear to me yet, the catalog, and the pulp task to dispatch upon completion. |
jeremycline
force-pushed
the
task-1195
branch
from
890a04e
to
46a512d
Compare
jeremycline
force-pushed
the
task-1195
branch
9 times, most recently
from
cb13cd4
to
818a7d7
Compare
|
General comment: Linux configuration files traditionally don't contain '_'. I know we do this in pulp (which I find annoying and odd) so I guess it's best to follow pulp convention. Just complaining, I guess. |
| # redirect_path: /streamer/ | ||
| # streamer_port: 8751 | ||
| # streamer_interfaces: localhost | ||
| # streamer_cache_timeout: 86400 |
There was a problem hiding this comment.
Instead of namespacing with streamer_, consider:
[streamer]
interfaces: localhost
port: 8751
cache_timeout: 86400
| mock_repo_controller.get_importer_by_id.assert_called_once_with(mock_catalog.plugin_id) | ||
|
|
||
| # Validate building and invoking the downloader | ||
| mock_importer.get_downloader.assert_called_once_with(mock_config, mock_catalog.url, k='v') |
|
Looks good overall but would like to discuss Streamer._download(). |
| @@ -94,6 +94,9 @@ | |||
| 'redirect_host': '', | |||
| 'redirect_port': '', | |||
| 'redirect_path': '', | |||
| 'streamer_port': '8751', | |||
| 'streamer_interfaces': 'localhost', | |||
| 'streamer_cache_timeout': '86400', | |||
There was a problem hiding this comment.
Same as other comment. consider separate section.
This commit adds the 'lazy' module inside of pulp.server. It also adds streamer settings to Pulp's server.conf.
jeremycline
added a commit
that referenced
this pull request
Oct 7, 2015
ref #1195 - Implement the pulp-streamer.
parthaa
added a commit
to parthaa/pulp
that referenced
this pull request
Jul 6, 2016
Fixed a bug that caused the wrong repo destination path to be verified on a ostree pull. Look at https://pulp.plan.io/issues/2065 for more info
parthaa
added a commit
to parthaa/pulp
that referenced
this pull request
Jul 6, 2016
Fixed a bug that caused the wrong repo destination path to be verified on a ostree pull. Look at https://pulp.plan.io/issues/2065 for more info
parthaa
added a commit
to parthaa/pulp
that referenced
this pull request
Jul 6, 2016
Fixed a bug that caused the wrong repo destination path to be verified on a ostree pull. Look at https://pulp.plan.io/issues/2065 for more info
parthaa
added a commit
to parthaa/pulp
that referenced
this pull request
Jul 6, 2016
Fixed a bug that caused the wrong repo destination path to be verified on a ostree pull. Look at https://pulp.plan.io/issues/2065 for more info
jeremycline
pushed a commit
to jeremycline/pulp
that referenced
this pull request
Jul 8, 2016
Fixed a bug that caused the wrong repo destination path to be verified on a ostree pull. Look at https://pulp.plan.io/issues/2065 for more info
jeremycline
added a commit
to jeremycline/pulp
that referenced
this pull request
Jul 8, 2016
The prefix stripping method used in the oid_validator failed if the prefix was _not_ found in the path. This fixes that particular issue, improves readability, and adds a unit test. fixes pulp#2065
jeremycline
added a commit
to jeremycline/pulp
that referenced
this pull request
Jul 11, 2016
The prefix stripping method used in the oid_validator failed if the prefix was _not_ found in the path. This fixes that particular issue, improves readability, and adds a unit test. fixes pulp#2065
jeremycline
pushed a commit
to jeremycline/pulp
that referenced
this pull request
Jul 11, 2016
Fixed a bug that caused the wrong repo destination path to be verified on a ostree pull. Look at https://pulp.plan.io/issues/2065 for more info
jeremycline
added a commit
to jeremycline/pulp
that referenced
this pull request
Jul 11, 2016
The prefix stripping method used in the oid_validator failed if the prefix was _not_ found in the path. This fixes that particular issue, improves readability, and adds a unit test. fixes pulp#2065
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the 'lazy' module inside of pulp.server.
It also adds streamer settings to Pulp's server.conf.