This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Convert the distributor manager to mongoengine friendly controller. #2233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -169,7 +168,7 @@ def setUp(self): | |||
| self.alias = (self.parentfs, self.parentfs) | |||
| Consumer.get_collection().remove() | |||
| Bind.get_collection().remove() | |||
| RepoDistributor.get_collection().remove() | |||
| model.Distributor.drop_collection() | |||
There was a problem hiding this comment.
Does dropping the collection also remove indicies? If so, then sticking with a remove call would be better.
There was a problem hiding this comment.
I believe dropping the collection does remove the indices as well.
| """ | ||
| try: | ||
| distributor_manager = manager_factory.repo_distributor_manager() | ||
| distributor_manager.set_distributor_scratchpad(self.repo_id, self.distributor_id, value) | ||
| qs = model.Distributor.objects.get_or_404 |
There was a problem hiding this comment.
It's worth noting that the except statement below will catch the MissingResource exception and turn it into whatever a DistributorConduitException is. :( You've preserved previous behavior, which is totally fine, but I thought I'd at least point it out that the result of calling get_or_404 is being diminished.
|
@mhrivnak thanks for the super fast review! |
|
ok test |
Replaces the old RepoDistributor model and all its uses with new model, pulp.server.db.model.Distributor. Also replaces all instances of using pymongo to access the the distributors collection with mongoengine. closes pulp#780
asmacdo
added a commit
that referenced
this pull request
Dec 16, 2015
Convert the distributor manager to mongoengine friendly controller.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the old RepoDistributor model and all its uses with new model,
pulp.server.db.model.Distributor. Also replaces all instances of using
pymongo to access the the distributors collection with mongoengine.
https://pulp.plan.io/issues/780