Skip to content
This repository has been archived by the owner on Dec 7, 2022. It is now read-only.

Closes #2481: Adds kobo as setup.py dependency #2894

Closed
wants to merge 1 commit into from

Conversation

bmbouter
Copy link
Member

With 2.10.0 Kobo became a spec file dependency, which
handled installing it for users. For developers, the
Ansible playbook seems to get its Pulp dependencies from
the setup.py files. This adds the kobo dependency to
the pulp.server setup.py file which fixes vagrant up
for developers.

https://pulp.plan.io/issues/2481

With 2.10.0 Kobo became a spec file dependency, which
handled installing it for users. For developers, the
Ansible playbook seems to get its Pulp dependencies from
the setup.py files. This adds the kobo dependency to
the pulp.server setup.py file which fixes `vagrant up`
for developers.

https://pulp.plan.io/issues/2481
@mention-bot
Copy link

@bmbouter, thanks for your PR! By analyzing the history of the files in this pull request, we identified @seandst, @mhrivnak and @jortel to be potential reviewers.

@werwty
Copy link
Contributor

werwty commented Dec 12, 2016

I think that if the spec file for ansible isn't resolving automatically maybe we should add kobo in pulp/devel since it's a developer issue: https://github.com/pulp/devel/blob/master/ansible/roles/dev/tasks/main.yml#L43

Also pulp does check the spec file dependencies here (I'm not sure why it's not getting kobo though): https://github.com/pulp/devel/blob/master/ansible/library/pulp_facts.py#L40

@ktdreyer
Copy link
Contributor

Just a heads' up that no one really knows who owns the Kobo module on PyPI. I've been trying to adopt it, to no avail: https://sourceforge.net/p/pypi/support-requests/632/

The result is that the PyPI version is much older than one that you will find at https://github.com/release-engineering/kobo or in Fedora.

@bmbouter
Copy link
Member Author

@ktdreyer Thank you for the heads up. We will change this to install via rpm, which looks very consistent on rhel and fedoras. Thanks!

@ktdreyer
Copy link
Contributor

Another option is to install with Git and the tag, like:

setup(
    ...,
    dependency_links=[
        'git+https://github.com/release-engineering/kobo@kobo-0.5.2#egg=kobo-0.5.2'
    ],

... Whatever's easier!

@bmbouter
Copy link
Member Author

We had a bug in our Ansible deployment which was causing kobo to not be installed via rpm as it was expected to. I'm closing this PR. Thanks @ktdreyer for the help anyway. We use kobo!

@bmbouter bmbouter closed this Dec 13, 2016
@bmbouter bmbouter deleted the 2481-Fruit-Mead branch December 13, 2016 22:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants