This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Remove db-reset script #3163
Merged
Remove db-reset script #3163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asmacdo
force-pushed
the
remove-db-reset
branch
from
97c2661
to
a4bf42f
Compare
dralley
approved these changes
Sep 22, 2017
Where it is used in this repo, it is replaced with pulp-manager use directly. re: pulp#3012
asmacdo
force-pushed
the
remove-db-reset
branch
from
a4bf42f
to
05b3ae3
Compare
asmacdo
commented
Sep 22, 2017
| - "platform/pulpcore/app/db-reset.sh && python manage.py test" | ||
| - "pulp-manager makemigrations pulp_app --noinput" | ||
| - "pulp-manager migrate auth --noinput" | ||
| - "pulp-manager migrate --noinput && pulp-manager test" |
There was a problem hiding this comment.
@dkliban, do you think that chaining only the final migrate will give us the intended result?
There was a problem hiding this comment.
maybe you can put an after_success section after the migrate step. and run test in there.
There was a problem hiding this comment.
There was a problem hiding this comment.
After IRC discussion, we decided to try moving this around in a separate change.
dkliban
approved these changes
Sep 22, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Where db-reset is used in this repo, it is replaced with pulp-manager use
directly.
https://pulp.plan.io/issues/3012
To be merged
along withafter pulp/devel#91re: #3012