This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Remove ability to delete content units #3407
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
commented
Apr 4, 2018
| pass | ||
|
|
||
|
|
||
| class CreateReadNamedModelViewSet(mixins.CreateModelMixin, |
There was a problem hiding this comment.
Am I the only one that finds this a liiiiittle bit ridiculous?
There was a problem hiding this comment.
Yes. Maybe have viewsets extend these mixins directly instead of creating a base viewset for each possible combination?
There was a problem hiding this comment.
I'll write up a refactor task which we can discuss next sprint planning
|
I tried testing this out but I am getting |
dralley
commented
Apr 4, 2018
| @@ -94,11 +94,13 @@ def import_serializers(self): | |||
| def import_viewsets(self): | |||
| # circular import avoidance | |||
| from pulpcore.app.viewsets import (GenericNamedModelViewSet, NamedModelViewSet, | |||
There was a problem hiding this comment.
Man, this code smells real bad.
|
Test failure is unrelated |
daviddavis
approved these changes
Apr 4, 2018
zjhuntin
pushed a commit
that referenced
this pull request
May 12, 2020
Update celery stack to v4 so we no longer have to maintain code for both 3 and 4 closes #3407 https://pulp.plan.io/issues/3407
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3445
https://pulp.plan.io/issues/3445