This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Update installation instructions #3865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both PyPI and source ones. closes #4356 https://pulp.plan.io/issues/4356
goosemania
commented
Feb 11, 2019
|
|
||
| $ pulp-manager runserver |
There was a problem hiding this comment.
Changed to pulp-manager for consistency here (since it's used in all the other instructions above).
Codecov Report
@@ Coverage Diff @@
## master #3865 +/- ##
=======================================
Coverage 55.79% 55.79%
=======================================
Files 66 66
Lines 2848 2848
=======================================
Hits 1589 1589
Misses 1259 1259Continue to review full report at Codecov.
|
daviddavis
approved these changes
Feb 11, 2019
asmacdo
reviewed
Feb 11, 2019
| @@ -43,20 +43,19 @@ PyPI Installation | |||
|
|
|||
| $ sudo apt-get install python3-venv | |||
|
|
|||
| 3. Install Pulp:: | |||
| 3. Install Pulp (install ``pulpcore-plugin``, and ``pulpcore`` itself will be installed as | |||
| a dependency):: | |||
There was a problem hiding this comment.
Maybe we should suggest that the user install the plugin they want, and pulpcore-plugin will be picked up as a dep. Is there any reason a user would install pulp without a plugin?
There was a problem hiding this comment.
That makes sense to me. Something like:
3. Installing a plugin will automatically install ``pulpcore`` and ``pulpcore-plugin``::
pip install pulp_file
Or you can install the individual packages of ``pulpcore`` and ``pulpcore-plugin``:
pip install pulpcore pulpcore-plugin
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both PyPI and source ones.
closes #4356
https://pulp.plan.io/issues/4356