This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
Use multi-resource locking when additional_repos override is passed #3947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dralley
force-pushed
the
2-master
branch
4 times, most recently
from
f9e629e
to
bf518c4
Compare
The RPM plugin needs to accept more than one source and destination repository for copy operations. The "additional_repos" flag is being added to deal with this. Core needs to look for this flag in the override config and then, when present, lock on all the repo ids present within as well as the directly-specified source and destination repo ids. re: #5067 https://pulp.plan.io/issues/5067
Locking all source repos too may degrade performance and despite a minimal risk by not doing so, the tradeoff is likely worth it. It is also the current behavior. re: #5067 https://pulp.plan.io/issues/5067
ipanova
approved these changes
Aug 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RPM plugin needs to accept more than one source and destination
repository for copy operations. The "additional_repos" flag is being
added to deal with this. Core needs to look for this flag in the
override config and then, when present, lock on all the repo ids present
within as well as the directly-specified source and destination repo
ids.
re: #5067
https://pulp.plan.io/issues/5067