This repository has been archived by the owner on Dec 7, 2022. It is now read-only.
1004346 - deal with bindings w/ binding_config = None #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| strategy = b['binding_config'].get('strategy', constants.DEFAULT_STRATEGY) | ||
| cfg = b['binding_config'] | ||
| if not isinstance(cfg, dict): | ||
| continue |
There was a problem hiding this comment.
If the config is not a dict, do we want to log an error?
|
Just wondering if we want some reporting if you get a config you're not expecting. Otherwise looks good. Merge on at will |
| a binding_config of None. | ||
| """ | ||
| collection = Bind.get_collection() | ||
| collection.update(QUERY, UPDATE, multi=True, safe=True) |
There was a problem hiding this comment.
Nice, no looping, so I love it 🎢
|
Looks good, merge on sir! |
jortel
added a commit
that referenced
this pull request
Sep 18, 2013
1004346 - deal with bindings w/ binding_config = None
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugzilla.redhat.com/show_bug.cgi?id=1004346
The problem is that non-nodes bindings are being created with (None) value for binding_config. IMHO, a configuration attribute should be defaulted to {} rather than None.