This repository has been archived by the owner on Jan 30, 2024. It is now read-only.
Add variables for molecule prepare.yml to clone the branches #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikedep333
added a commit
to mikedep333/galaxy_ng_prerequisites
that referenced
this pull request
Apr 22, 2020
Required PR: pulp/pulp_installer#272 re: #6547 [noissue]
mikedep333
force-pushed
the
6547_molecule_clone_branches
branch
from
d14fb80
to
a4a957c
Compare
mikedep333
added a commit
to mikedep333/pulp.pulp-rpm-prerequisites
that referenced
this pull request
Apr 23, 2020
…ey test against fixes: #6548 Required PR: pulp/pulp_installer#272
|
Does it still WIP? |
Kind of. I'm double-checking my work now (for proper design, and correctness. And checking CI output) before I ask you to review. Thank you for being so attentive. EDIT: I should also create another PR for pulp_rpm_prerequisites with branch 3.3 variables. I should technically create a branch anyway, but I need it to test this PR. |
mikedep333
force-pushed
the
6547_molecule_clone_branches
branch
3 times, most recently
from
1aaf7a3
to
0aae56b
Compare
So we can manually verify that the correct versions were installed. Also verifies that the status page is accessible; that pulpcore-api and nginx are basically working. fixes: #6585
giving it the capability to do mounts like PrivateTmp re: #6586 [noissue]
mikedep333
force-pushed
the
6547_molecule_clone_branches
branch
from
0aae56b
to
484a708
Compare
fao89
approved these changes
May 1, 2020
Comment on lines
+19
to
+27
| # pulp_install_plugins has the following molecule (CI) only subfields: | ||
| # item.value.git_repo: The git repo to clone from for source test scenarios. | ||
| # item.value.git_commitish: The commitish (branch, tag) to checkout for source test scenarios. | ||
| # | ||
| # pulp_install_plugins has the following not advertised subfield because it is | ||
| # only used for CI purposes currently, and the related logic (conflicts with | ||
| # version) are not done yet: | ||
| # item.value.pip_version_specifier: One of more pip version specifiers, | ||
| # separated by commas. |
There was a problem hiding this comment.
I would move these comments to somewhere under molecule dir
|
Closing this for now. Let's get back to this when we have time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #6547