1782 - reboot_suggested is False by default if during unit upload the… #842
Conversation
…re was not specified any value. closes pulp#1782 https://pulp.plan.io/issues/1782
|
@midnightercz please confirm that this kind of solution meets your needs. |
|
looks good |
|
What do you think about testing this? Would it be straight-forward to unit test? Or are we better off sticking to smash tests? |
|
@mhrivnak All tests for updateinfo are broken and skipped now. So we would probably need first to fix them and add new, or stick to smash tests as you suggested. |
|
This function is unreasonably large (through no fault of this PR) and thus presents a real challenge for testing. @ipanova I'm willing to LGTM if you can take some action that guarantees that we won't forget that this isn't tested (file a Redmine ticket to thoroughly refactor and test this function, or file a pulp-smash ticket to test this specific behavior). |
|
thanks @rbarlow! i filled the pulp-smah issue to test this specific case pulp/pulp-smash#214 |
…re was not specified any value.
closes #1782
https://pulp.plan.io/issues/1782