Removing _type field

closes #5550
https://pulp.plan.io/issues/5550

 Required PR: pulp/pulp_file#284
 Required PR: pulp/pulpcore-plugin#137
 Required PR: pulp/pulp-smash#1220
 Required PR: pulp/pulp-certguard#31

CHANGES/5550.removal

@@ -0,0 +1 @@
+Removing base serializer field: `_type` .

docs/contributing/architecture/rest-api.rst

@@ -228,7 +228,7 @@ representing the Master Model in a Master/Detail relationship, and every Seriali
 Detail Models must subclass their respective Master Serializer.
 
 Furthermore, every Serializer representing a Master Model should subclass a special Serializer
-created for Master/Detail models, :class:`pulpcore.app.serializers.base.MasterModelSerializer`. This
+created for Master/Detail models, :class:`pulpcore.app.serializers.base.ModelSerializer`. This
 Serializer includes a definition for the `type` field present on all models inheriting from
 :class:`pulpcore.app.models.MasterModel`, and also identifies the `type` field as filterable,
 centralizing common behavior that we're likely to want in all Serializers representing Models

pulpcore/app/serializers/__init__.py

@@ -6,7 +6,6 @@
     DetailIdentityField,
     DetailRelatedField,
     IdentityField,
-    MasterModelSerializer,
     ModelSerializer,
     NestedIdentityField,
     NestedRelatedField,

pulpcore/app/serializers/base.py

@@ -78,38 +78,6 @@ def validate(self, data):
         return data
 
 
-class MasterModelSerializer(ModelSerializer):
-    """
-    Base serializer for all Master/Detail Models.
-
-    When subclassing this, all subclasses should explicitly inherit the fields of their parent
-    in their Meta options class. For example:
-
-        class MasterSerializer(MasterModelSerializer):
-            foo = SerializerField()
-
-            class Meta:
-                fields = MasterModelSerializer.Meta.fields + ('foo',)
-
-        class DetailSerializer(MasterSerializer):
-            bar = SerializerField()
-
-            class Meta:
-                fields = MasterSerializer.Meta.fields + ('bar',)
-
-    This ensures that fields are represented consistently throughout the API, and Detail Model
-    types are cast down before representation.
-
-    Other Meta attributes, such as `filterset_fields`, should also be inherited in this way
-    as-needed.
-
-    """
-    _type = serializers.CharField(read_only=True)
-
-    class Meta:
-        fields = ModelSerializer.Meta.fields + ('_type',)
-
-
 class MatchingNullViewName(object):
     """Object that can be used as the default view name for detail fields
 

pulpcore/app/serializers/content.py

@@ -11,12 +11,12 @@
 UNIQUE_ALGORITHMS = ['sha256', 'sha384', 'sha512']
 
 
-class BaseContentSerializer(base.MasterModelSerializer):
+class BaseContentSerializer(base.ModelSerializer):
     pulp_href = base.DetailIdentityField()
 
     class Meta:
         model = models.Content
-        fields = base.MasterModelSerializer.Meta.fields
+        fields = base.ModelSerializer.Meta.fields
 
 
 class NoArtifactContentSerializer(BaseContentSerializer):

pulpcore/app/serializers/publication.py

@@ -10,15 +10,14 @@
     BaseURLField,
     DetailIdentityField,
     DetailRelatedField,
-    MasterModelSerializer,
     ModelSerializer,
     NestedRelatedField,
     RelatedField,
     validate_unknown_fields,
 )
 
 
-class PublicationSerializer(MasterModelSerializer):
+class PublicationSerializer(ModelSerializer):
     pulp_href = DetailIdentityField()
     repository_version = NestedRelatedField(
         view_name='versions-detail',
@@ -64,14 +63,14 @@ def validate(self, data):
     class Meta:
         abstract = True
         model = models.Publication
-        fields = MasterModelSerializer.Meta.fields + (
+        fields = ModelSerializer.Meta.fields + (
             'publisher',
             'repository_version',
             'repository'
         )
 
 
-class ContentGuardSerializer(MasterModelSerializer):
+class ContentGuardSerializer(ModelSerializer):
     pulp_href = DetailIdentityField()
 
     name = serializers.CharField(
@@ -85,13 +84,13 @@ class ContentGuardSerializer(MasterModelSerializer):
 
     class Meta:
         model = models.ContentGuard
-        fields = MasterModelSerializer.Meta.fields + (
+        fields = ModelSerializer.Meta.fields + (
             'name',
             'description'
         )
 
 
-class BaseDistributionSerializer(MasterModelSerializer):
+class BaseDistributionSerializer(ModelSerializer):
     """
     The Serializer for the BaseDistribution model.
 

pulpcore/app/serializers/repository.py

@@ -9,7 +9,6 @@
     DetailIdentityField,
     IdentityField,
     LatestVersionField,
-    MasterModelSerializer,
     ModelSerializer,
     NestedIdentityField,
     NestedRelatedField,
@@ -48,7 +47,7 @@ class Meta:
                                                 'plugin_managed', 'description')
 
 
-class RemoteSerializer(MasterModelSerializer):
+class RemoteSerializer(ModelSerializer):
     """
     Every remote defined by a plugin should have a Remote serializer that inherits from this
     class. Please import from `pulpcore.plugin.serializers` rather than from this module directly.
@@ -123,7 +122,7 @@ class RemoteSerializer(MasterModelSerializer):
     class Meta:
         abstract = True
         model = models.Remote
-        fields = MasterModelSerializer.Meta.fields + (
+        fields = ModelSerializer.Meta.fields + (
             'name', 'url', 'ssl_ca_certificate', 'ssl_client_certificate', 'ssl_client_key',
             'ssl_validation', 'proxy_url', 'username', 'password', 'pulp_last_updated',
             'download_concurrency', 'policy'
@@ -150,7 +149,7 @@ class RepositorySyncURLSerializer(serializers.Serializer):
     )
 
 
-class PublisherSerializer(MasterModelSerializer):
+class PublisherSerializer(ModelSerializer):
     """
     Every publisher defined by a plugin should have an Publisher serializer that inherits from this
     class. Please import from `pulpcore.plugin.serializers` rather than from this module directly.
@@ -168,12 +167,12 @@ class PublisherSerializer(MasterModelSerializer):
     class Meta:
         abstract = True
         model = models.Publisher
-        fields = MasterModelSerializer.Meta.fields + (
+        fields = ModelSerializer.Meta.fields + (
             'name', 'pulp_last_updated',
         )
 
 
-class ExporterSerializer(MasterModelSerializer):
+class ExporterSerializer(ModelSerializer):
     pulp_href = DetailIdentityField()
     name = serializers.CharField(
         help_text=_('The exporter unique name.'),
@@ -191,7 +190,7 @@ class ExporterSerializer(MasterModelSerializer):
     class Meta:
         abstract = True
         model = models.Exporter
-        fields = MasterModelSerializer.Meta.fields + (
+        fields = ModelSerializer.Meta.fields + (
             'name',
             'pulp_last_updated',
             'last_export',