Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't install scoped packages properly #14

Open
5 tasks done
sertonix opened this issue Oct 27, 2022 · 3 comments
Open
5 tasks done

can't install scoped packages properly #14

sertonix opened this issue Oct 27, 2022 · 3 comments
Labels
bug Something isn't working question Further information is requested

Comments

@sertonix
Copy link
Contributor

sertonix commented Oct 27, 2022

Thanks in advance for your bug report!

  • Have you reproduced issue in safe mode?
  • Have you used the debugging guide to try to resolve the issue?
  • Have you checked our FAQs to make sure your question isn't answered there?
  • Does your issue already exist?
  • Have you checked you are on the latest release of Pulsar?

What happened?

It is not properly possible to install a scoped package. The first part of the name is interpreted as package name. eg. @sertonix if the package is called @sertonix/test
When you try to uninstall the package it gives an error because the package.json is not in the expected path.

What steps are needed to reproduce this?

  1. create local package
  2. set the name to a scoped one. eg. @sertonix/test
  3. install package with apm link <path>
  4. check settings
  5. the package will have the name of the scope. eg. @sertonix

Additional Information:

the / is interpreted as a sub folder. To prevent this an escape sequence is required that does not contain / or \\. Maybe use encodeURIComponent for that.

@sertonix sertonix added bug Something isn't working question Further information is requested labels Oct 27, 2022
@sertonix sertonix changed the title unable to install scoped packages can't install scoped packages properly Oct 27, 2022
@GuilleW
Copy link
Contributor

GuilleW commented Nov 6, 2022

what about a test and split after / ?
if test -> test
else @sertonix/test -> split after / and rename test folder ?

@sertonix
Copy link
Contributor Author

sertonix commented Nov 6, 2022

That would not allow a package named test besides a package named @sertonix/test cause they would both have the same folder name

@GuilleW
Copy link
Contributor

GuilleW commented Nov 14, 2022

We can use @ for scoped packages.
If a package start with @ , then it's a scoped packages. One or more packages can be found inside ?
So you can add your @sertonix package, with your package test inside, along with your other packages.
What do you think ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants