Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not crash if there is no commit #41

Open
trickypr opened this issue Jul 13, 2023 · 0 comments
Open

Do not crash if there is no commit #41

trickypr opened this issue Jul 13, 2023 · 0 comments

Comments

@trickypr
Copy link
Member

Some people are experiencing crashes when building without a commit. e.g.

Error: Command failed with exit code 128: git rev-parse HEAD
fatal: not a git repository (or any of the parent directories): .git

We should:

  1. Check if it is in a git repo
  2. Check if there is a commit

If neither of those conditions are met, we should warn the user and use a bogus commit hash (e.g. 0000000 or something)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trickypr