Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should error on missing stack configuration #22

Closed
chrisportela opened this issue Jan 21, 2020 · 3 comments
Closed

Should error on missing stack configuration #22

chrisportela opened this issue Jan 21, 2020 · 3 comments
Assignees
@stack72
Milestone
0.53

Comments

@chrisportela
Copy link

We were getting passing builds in our deploy workflow, but the task was actually not configured for this branch. We're using the config as explained in the README.

Is there something we missed or need to add in our configuration to make sure the task fails if it can't find a proper configuration?
@pgavlin
Copy link
Member

pgavlin commented Jan 22, 2020

cc @chrsmith @joeduffy

@stack72 stack72 mentioned this issue Dec 31, 2020
Closed
29 tasks
@stack72
Copy link
Contributor

stack72 commented Dec 31, 2020

Closed as being tracked in #40

@stack72 stack72 closed this as completed Dec 31, 2020
@leezen leezen reopened this Jan 4, 2021
@stack72 stack72 assigned stack72 and unassigned chrsmith Feb 26, 2021
@stack72 stack72 added this to the 0.53 milestone Feb 26, 2021
@stack72
Copy link
Contributor

stack72 commented Feb 26, 2021

I am closing this out as we have just released v2 of our Action which is based on TypeScript and addresses this issue

@stack72 stack72 closed this as completed Feb 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stack72 stack72

Labels
None yet
Projects
None yet
Milestone
0.53
Development

No branches or pull requests
5 participants
@stack72 @chrisportela @leezen @pgavlin @chrsmith