Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have an ability to change pulumi cli version #437

Closed
XBeg9 opened this issue Nov 4, 2021 · 4 comments · Fixed by #661
Closed

Have an ability to change pulumi cli version #437

XBeg9 opened this issue Nov 4, 2021 · 4 comments · Fixed by #661
Labels
resolution/fixed This issue was fixed

Comments

@XBeg9
Copy link

XBeg9 commented Nov 4, 2021

const pulumiVersion = '^3';

Is there a specific reason why we can't control pulumi cli version?

@stack72
Copy link
Contributor

stack72 commented Nov 4, 2021

Hi @XBeg9

So the use of the CLI internally to the actions is purely an implementation detail based on the fact that the action uses the automation api. The automation api needs the cli and it's kinda coupled with it. If you try and use the automation api with a non-compatible version of the cli then an error can occur

So we are coupling the version of the automation api with the version of the cli

If you feel this is bad practice then we can change it but it would still need to be the default version that is coupled.

Paul

@Place1
Copy link

Place1 commented Jun 22, 2022

I've experienced bugs in minor/patch releases of the Pulumi CLI. It's not fun but it's something that happens to all software.

It'd be great if the action allowed users to specify which CLI version they need to work around bugs :)

@simenandre
Copy link
Contributor

We could check if the user-defined version is within the range the action requires. This could be something the end user sees as a warning?

What do you guys think, @Place1 and @stack72?

@RobbieMcKinstry RobbieMcKinstry linked a pull request Jul 1, 2022 that will close this issue
@RobbieMcKinstry
Copy link
Contributor

I'm suggesting we add a warning to check if the requested version is beneath v3 in this PR.

@pulumi-bot pulumi-bot added the resolution/fixed This issue was fixed label Jul 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants