Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node.js 12 runtime for GH actions is deprecated #752

Closed
RobbieMcKinstry opened this issue Oct 11, 2022 · 1 comment · Fixed by #753
Closed

Node.js 12 runtime for GH actions is deprecated #752

RobbieMcKinstry opened this issue Oct 11, 2022 · 1 comment · Fixed by #753
Assignees
Labels
blocked The issue cannot be resolved without 3rd party action. impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Milestone

Comments

@RobbieMcKinstry
Copy link
Contributor

RobbieMcKinstry commented Oct 11, 2022

TL;DR

On 18 January 2023 or shortly thereafter, we will be upgrading the JavaScript runtime for this action to Node 16, and likely cutting a new major release. Environments running GHE v3.3 or earlier will no longer work with this forthcoming release.

Background

Node 12 was sunset on 30 Apr 2022. In non-Enterprise environments, GitHub Actions supports JavaScript-based actions running on either Node 12 or Node 16.

In GitHub Enterprise, support for Node 16 was added in GitHub Enterprise v3.4.0, released on 15 March 2022.
We intend this action to work for all GitHub users, both SaaS users, and GitHub Enterprise users. This action will continue to use Node 12 until all maintained versions of GitHub Enterprise have Node 16 support. We don't want to break users running a maintained, supported versions of GHE that simply can't execute our action.

As a result, this Action will switch to Node 16 once GHE v3.3 is sunset. That date is 18 January 2023. At that time, all active versions of GHE will be able to execute this action. We've updated the README to reflect this support policy.

Until 18 January 2023, you may see the following warning:

Node.js 12 actions are deprecated. For more information see: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/. Please update the following actions to use Node.js 16: pulumi/actions

image

Additional Context

For more information, please see GitHub's deprecation notice for Node 12 actions.

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@RobbieMcKinstry RobbieMcKinstry added impact/breaking Fixing this issue will require a breaking change blocked The issue cannot be resolved without 3rd party action. kind/bug Some behavior is incorrect or out of spec labels Oct 11, 2022
@RobbieMcKinstry RobbieMcKinstry self-assigned this Oct 11, 2022
@RobbieMcKinstry RobbieMcKinstry pinned this issue Oct 11, 2022
@RobbieMcKinstry
Copy link
Contributor Author

Update: it appears GHE has rescheduled the deprecation until 18 Jan. 2023. I've updated the issue text to reflect this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked The issue cannot be resolved without 3rd party action. impact/breaking Fixing this issue will require a breaking change kind/bug Some behavior is incorrect or out of spec resolution/fixed This issue was fixed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants