Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test stack upgrades #325

Closed
1 of 3 tasks
t0yv0 opened this issue Feb 6, 2023 · 5 comments
Closed
1 of 3 tasks

Test stack upgrades #325

t0yv0 opened this issue Feb 6, 2023 · 5 comments
Labels
kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue

Comments

@t0yv0
Copy link
Member

t0yv0 commented Feb 6, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

We should consider testing for no-changes provider upgrades.

There is a growing number of issues with provider upgrades generating unexpected changes in the users's stacks:

Some of these issues could have been detected by test automation checking specifically for the upgrade scenario. We currently do not know of an example of such automation.

  • add pulumi-random test for stack upgrades (post mortem follow-up)
  • discuss design and see anything can be upstreamed to ProgramTest
  • figure out a plan for introducing this testing across other providers

Affected area/feature

Provider testing.

@t0yv0 t0yv0 added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team and removed needs-triage Needs attention from the triage team labels Feb 6, 2023
@t0yv0 t0yv0 self-assigned this Feb 9, 2023
@t0yv0 t0yv0 added this to the 0.84 milestone Feb 9, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Feb 9, 2023

Implemented for Random provider: pulumi/pulumi-random#263

@AaronFriel AaronFriel modified the milestones: 0.84, 0.85 Feb 13, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Feb 13, 2023

Given difficulties implementing this for random, this is now feature request against the ProgramTest framework.

pulumi/pulumi#12125

Once there's good options in the framework I recommend we circle back and ensure every one of our providers is covering the upgrade scenario for common resources with at least 1 test.

@t0yv0
Copy link
Member Author

t0yv0 commented Feb 17, 2023

Plus one P1 on this, will be propagating the ad-hoc test to TLS.

@mikhailshilkov mikhailshilkov removed this from the 0.85 milestone Apr 3, 2023
@t0yv0 t0yv0 removed their assignment Jun 26, 2023
@t0yv0
Copy link
Member Author

t0yv0 commented Aug 28, 2023

Closing in favor of #325

@t0yv0 t0yv0 closed this as completed Aug 28, 2023
@pulumi-bot
Copy link

Cannot close issue:

  • does not have required labels: resolution/

Please fix these problems and try again.

@pulumi-bot pulumi-bot reopened this Aug 28, 2023
@t0yv0 t0yv0 added the resolution/duplicate This issue is a duplicate of another issue label Aug 28, 2023
@t0yv0 t0yv0 closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features resolution/duplicate This issue is a duplicate of another issue
Projects
None yet
Development

No branches or pull requests

4 participants