Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how secrets are handled in Dynamic Providers docs #12059

Open
lukehoban opened this issue Jun 15, 2024 · 1 comment
Open

Improve how secrets are handled in Dynamic Providers docs #12059

lukehoban opened this issue Jun 15, 2024 · 1 comment
Assignees
Labels
area/docs Improvements or additions to documentation kind/enhancement Improvements or new features
Milestone

Comments

@lukehoban
Copy link
Member

lukehoban commented Jun 15, 2024

Docs like https://www.pulumi.com/docs/concepts/resources/dynamic-providers/#example-github-labels-rest-api use an approach to manage secrets with dynamic providers which doesn't work well in practice. We've added improved support for capturing Secret values into dynamic providers reently, and should adopt those into these examples, and also likely add explicit documentation about how secrets can be used with Dynamic Providers.

@github-actions github-actions bot added the needs-triage Needs attention from the triage team label Jun 15, 2024
@interurban interurban added area/docs Improvements or additions to documentation kind/enhancement Improvements or new features labels Jun 17, 2024
@justinvp
Copy link
Member

We should update the Node.js example along the lines of https://github.com/pulumi/pulumi/blob/master/tests/examples/dynamic-provider/secrets/index.ts from pulumi/pulumi#13329

And we need to get pulumi/pulumi#15864 merged, and then update the Python example similarly.

@interurban interurban removed the needs-triage Needs attention from the triage team label Jun 24, 2024
@interurban interurban self-assigned this Jun 24, 2024
@interurban interurban added this to the 0.106 milestone Jun 24, 2024
@cnunciato cnunciato self-assigned this Jul 1, 2024
@cnunciato cnunciato modified the milestones: 0.106, 0.107 Jul 1, 2024
@interurban interurban modified the milestones: 0.107, 0.108 Jul 24, 2024
@interurban interurban modified the milestones: 0.108, 0.109 Aug 21, 2024
@interurban interurban modified the milestones: 0.109, 0.110 Sep 13, 2024
@interurban interurban modified the milestones: 0.110, 0.111 Oct 1, 2024
@interurban interurban modified the milestones: 0.111, 0.112 Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Improvements or additions to documentation kind/enhancement Improvements or new features
Projects
Status: 🎬 Ready
Development

No branches or pull requests

4 participants