Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address review feedback from first round of example improvements #6

Closed
5 of 6 tasks
lindydonna opened this issue Dec 18, 2017 · 3 comments
Closed
5 of 6 tasks

Address review feedback from first round of example improvements #6

lindydonna opened this issue Dec 18, 2017 · 3 comments
Assignees
@lindydonna
Labels
area/examples kind/enhancement Improvements or new features
Milestone
0.11

Comments

@lindydonna
Copy link
Contributor

lindydonna commented Dec 18, 2017 •
edited
Loading

Incorporate the review feedback in the PR here: #5
@lindydonna lindydonna self-assigned this Dec 18, 2017
@lindydonna lindydonna added this to the 0.9.1 milestone Dec 18, 2017
@lindydonna lindydonna mentioned this issue Dec 18, 2017
Merged
@lindydonna lindydonna changed the title Address PR feedback from first round of example improvements Address review feedback from first round of example improvements Dec 18, 2017
@lindydonna lindydonna mentioned this issue Dec 20, 2017
Closed
@joeduffy joeduffy modified the milestones: 0.9.1, 0.9.2 Dec 26, 2017
@joeduffy
Copy link
Member

@lindydonna moving to 0.9.2, as I am trying to close out 0.9.1 right now. LMK if you had planned to get to this within the next day or two and we can bring it back in.

@lindydonna lindydonna modified the milestones: 0.9.2, 0.10 Jan 8, 2018
@lindydonna lindydonna modified the milestones: 0.10, 0.11 Jan 31, 2018
@lindydonna
Copy link
Contributor Author

Moving to M11, but this needs to be done early in M11, as good examples are critical.

@joeduffy joeduffy modified the milestones: 0.11, 0.12 Feb 12, 2018
@lindydonna lindydonna modified the milestones: 0.12, 0.11 Mar 7, 2018
@lindydonna
Copy link
Contributor Author

Most of this is fixed in #16. Opening a new issue for the use of secrets in the voting-app example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lindydonna lindydonna

Labels
area/examples kind/enhancement Improvements or new features
Projects
None yet
Milestone
0.11
Development

No branches or pull requests
2 participants
@joeduffy @lindydonna