Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not skip PreviewOnly test in -short mode #17

Open
t0yv0 opened this issue Oct 12, 2023 · 0 comments
Open

Do not skip PreviewOnly test in -short mode #17

t0yv0 opened this issue Oct 12, 2023 · 0 comments
Labels
kind/bug Some behavior is incorrect or out of spec

Comments

@t0yv0
Copy link
Member

t0yv0 commented Oct 12, 2023

What happened?

Currently PreviewOnly upgrade tests skip themselves in -short mode however this is not ideal as it overloads another emerging convention we have in places like azure-native. Specifically, -short is used to skip very long running integration tests (think 20 minutes) but allow faster running integration tests (think 1 minute) to pass through. PreviewOnly tests are more in the 1 minute range so they should be permitted through -short to be conventional here.

Instead if #14 is adopted skip these tests when creds are not available, if the user opts into running in creds-free mode.

Example

N/A

Output of pulumi about

N/A

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team and removed needs-triage Needs attention from the triage team labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Development

No branches or pull requests

1 participant