Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert no changes after a pulumi up --yes #29

Open
iwahbe opened this issue Nov 3, 2023 · 1 comment
Open

Assert no changes after a pulumi up --yes #29

iwahbe opened this issue Nov 3, 2023 · 1 comment
Labels
kind/engineering Work that is not visible to an external user kind/enhancement Improvements or new features

Comments

@iwahbe
Copy link
Member

iwahbe commented Nov 3, 2023

Hello!

  • Vote on this issue by adding a 👍 reaction
  • If you want to implement this feature, comment to let us know (we'll work with you on design, scheduling, etc.)

Issue details

There are situations where we expect to see a diff during an upgrade, for example gcp v6 to v7 adds a new output field on many resources. When running replay tests for this scenario, it is ok that pulumi up shows +pulumiLabels. However, after running pulumi up --yes, we should be able to run pulumi preview --expect-no-changes and see no changes. For well behaved providers, it is always the case that pulumi up --yes && pulumi preview --expect-no-changes succeeds.

When an upgrade test asserts on a state transition (modeling pulumi up --yes, it should then assert that Diff(oldState, oldState) sends DIFF_NONE.

This will provide advanced warning for bugs such as https://pulumi.slack.com/archives/CBVJAP46L/p1698974120057579.

Affected area/feature

@iwahbe iwahbe added kind/enhancement Improvements or new features needs-triage Needs attention from the triage team labels Nov 3, 2023
@t0yv0
Copy link
Member

t0yv0 commented Dec 5, 2023

Implies #36 which was skipped for lack of time but looks like we really need that.

@mjeffryes mjeffryes added kind/engineering Work that is not visible to an external user and removed needs-triage Needs attention from the triage team labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/engineering Work that is not visible to an external user kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

3 participants