aws implementation points to Terraform help page

[cowwoc]

Given:

import * as pulumi from "@pulumi/pulumi";
import * as aws from "@pulumi/aws";
import * as awsx from "@pulumi/awsx";

// Create an AWS resource (S3 Bucket)
const bucket = new aws.s3.Bucket("my-bucket");

// Export the name of the bucket
export const bucketName = bucket.id;

When I run pulumi up I get:

Previewing update (dev):

     Type                 Name         Plan       Info                                                                                                                                                                                                                                                                        +   pulumi:pulumi:Stack  sparrow-dev  create                                                                                                                                                                                                                                                                                     └─ aws:s3:Bucket     my-bucket               1 error                                                                                                                                                                                                                                                                    
Diagnostics:
  aws:s3:Bucket (my-bucket):
    error: No valid credential sources found for AWS Provider.
        Please see https://terraform.io/docs/providers/aws/index.html for more information on
        providing credentials for the AWS Provider

Notice that the error message asks me to visit terraform's website.

[pgavlin]

Thanks for filing! I'm going to move this to https://github.com/pulumi/pulumi-aws.

[lukehoban]

I am pretty sure this was regressed in #580, related to the comment I left at the time: #580 (comment).

Looking at where this error message is produced, all 4 cases are as part of getting an error from creds.Get() which that PR removed.

cc @jen20

[lukehoban]

In particular - that discussion notes:

I don't think removing the call to Get on the returned Credentials struct is strictly necessary to fix the bug, but I also don't think it buys us anything to do it.

However, the issue here is exactly the reason we need to do it - to report good error messages early for cases where creds.Get() will fail.

[stack72]

Hi all,

I have tried to recreate this today - when using the latest pulumi-aws from npm, I get the following error when not supplying any credentials at all:

$ pulumi up
Previewing update (dev):

     Type                 Name                       Plan       Info
 +   pulumi:pulumi:Stack  missing-creds-message-dev  create
     └─ aws:s3:Bucket     my-bucket                             1 error

Diagnostics:
  aws:s3:Bucket (my-bucket):
    error: unable to discover AWS AccessKeyID and/or SecretAccessKey - see https://pulumi.io/install/aws.html for details on configuration

This is what we had hoped would happen with #580

@cowwoc if you still see this error on the latest version of pulumi-aws, then please do let me know

Paul