Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5 Major Version Release: Normalize input dropletId to the same type as id #600

Open
iwahbe opened this issue Jan 25, 2024 · 2 comments
Open
Labels
kind/enhancement Improvements or new features

Comments

@iwahbe
Copy link
Member

iwahbe commented Jan 25, 2024

The upstream provider models id and dropletId as an integer. Pulumi always models id as a string, which works well for most providers... but not this one. For the next major version release of this provider, we should switch over to modeling dropletId as a string, allowing the convenient passing of a droplet's id field to a input that accepts a dropletId.

The current workaround is to parse the id field before passing it into dropletId:

new digitalocean.ReservedIp("vpnReservedIp", {
  dropletId: vpnDroplet.id.apply(parseInt(id),
  region: vpnDroplet.region,
});

This will fix:

@iwahbe iwahbe added the kind/enhancement Improvements or new features label Jan 25, 2024
@iwahbe iwahbe pinned this issue Jan 25, 2024
@iwahbe
Copy link
Member Author

iwahbe commented Jan 25, 2024

If you feel that this issue is sufficiently painful to motivate a major version bump all on it's own, please 👍 this comment.

If you feel that this issue should not motivate a major version bump, please 👎 this comment.

@nmathew98
Copy link

@iwahbe can we update the docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

2 participants