Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade grpc-core Java SDK dependency to avoid CWE-404 #695

Closed
Tracked by #598
t0yv0 opened this issue Jun 23, 2022 · 4 comments
Closed
Tracked by #598

Upgrade grpc-core Java SDK dependency to avoid CWE-404 #695

t0yv0 opened this issue Jun 23, 2022 · 4 comments
Assignees
Labels
area/build dependencies Pull requests that update a dependency file kind/bug Some behavior is incorrect or out of spec language/java resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Milestone

Comments

@t0yv0
Copy link
Member

t0yv0 commented Jun 23, 2022

What happened?

https://ossindex.sonatype.org/vulnerability/sonatype-2021-0818?component-type=maven&component-name=io.grpc%2Fgrpc-core&utm_source=ossindex-client&utm_medium=integration&utm_content=1.7.0

CWE-404: Improper Resource Shutdown or Release

Note that previously we noticed some issues with tests not passing after upgrading gRPC deps, so this might need some work.

Steps to reproduce

Expected Behavior

Actual Behavior

Versions used

No response

Additional context

No response

Contributing

Vote on this issue by adding a 👍 reaction.
To contribute a fix for this issue, leave a comment (and link to your pull request, if you've opened one already).

@t0yv0 t0yv0 added kind/bug Some behavior is incorrect or out of spec needs-triage Needs attention from the triage team labels Jun 23, 2022
@dixler dixler added size/S Estimated effort to complete (1-2 days). dependencies Pull requests that update a dependency file and removed needs-triage Needs attention from the triage team labels Jun 24, 2022
@pawelprazak
Copy link
Contributor

Not sure I understand this one, do I understand correctly it was reverted?
grpc/grpc-java#8361

@t0yv0
Copy link
Member Author

t0yv0 commented Jul 6, 2022

I've reverted it because it made our tests fail. We probably need to try again, this time paying attention to why the tests fail and if there is any way to mitigate the problem and upgrade after all.

@t0yv0
Copy link
Member Author

t0yv0 commented Aug 12, 2022

This is now fixed (dep upgraded) + detailed workaround for the minimal example in #806

@t0yv0 t0yv0 closed this as completed Aug 12, 2022
@pulumi-bot pulumi-bot reopened this Aug 12, 2022
@pulumi-bot
Copy link
Contributor

Cannot close issue without required labels: resolution/

@t0yv0 t0yv0 added the resolution/fixed This issue was fixed label Aug 12, 2022
@t0yv0 t0yv0 added this to the 0.76 milestone Aug 12, 2022
@t0yv0 t0yv0 self-assigned this Aug 12, 2022
@t0yv0 t0yv0 closed this as completed Aug 12, 2022
@t0yv0 t0yv0 mentioned this issue Aug 16, 2022
40 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/build dependencies Pull requests that update a dependency file kind/bug Some behavior is incorrect or out of spec language/java resolution/fixed This issue was fixed size/S Estimated effort to complete (1-2 days).
Projects
None yet
Development

No branches or pull requests

5 participants