Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement observability on garbage collection needs of failed Stack runs #10

Closed
2 tasks
metral opened this issue Jun 26, 2020 · 3 comments
Closed
2 tasks
Labels
kind/enhancement Improvements or new features
Milestone

Comments

@metral
Copy link
Contributor

metral commented Jun 26, 2020

In the scenarios that stacks can be stuck in a failure, resources in flight could be in a pending or failed state.
We should provide the information listed in the pending_operations.

  • Log the resources orphaned in the update
  • Reflect the log of orphaned resources in CR spec.status field
@metral metral self-assigned this Jun 26, 2020
@metral metral changed the title Implement garbage collection of failed Stack runs (opt-in) Implement garbage collection of failed Stack runs Jun 26, 2020
@leezen leezen added this to the current milestone Jul 14, 2020
@leezen leezen removed this from the current milestone Jul 27, 2020
@metral metral removed the Shippable label Jul 28, 2020
@rodcloutier
Copy link

Could the issue be a little more fleshed out?
What type of resources are orphaned?
Do you mean to implement garbage collection per say or just add observability on orphan resources?

@metral metral changed the title Implement garbage collection of failed Stack runs Implement observability on garbage collection needs of failed Stack runs Oct 26, 2020
@metral
Copy link
Contributor Author

metral commented Oct 26, 2020

Thank you for your questions. We've updated the issue title and desc to better reflect the scope of this issue to be about informing the user of what operations are stuck in a pending state.

@lukehoban
Copy link
Member

I don't believe there's any actual "garbage collection" we would do here. I think this is just another part of what's tracked in #9 - to expose potentially-leaked resources into the CR. I'll add this as a bullet there to track in one place.

@leezen leezen modified the milestones: current, 0.47 Nov 18, 2020
@infin8x infin8x added the kind/enhancement Improvements or new features label Jul 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Improvements or new features
Projects
None yet
Development

No branches or pull requests

5 participants