We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I've been using the following helm chart transformation for removing helm hooks:
function removeHelmTests() { return (obj: any) => { if (!obj) { return; } if (obj.metadata && obj.metadata.annotations && obj.metadata.annotations['helm.sh/hook']) { // transforms in nodejs expects you to mutate input object, not return a new one. // https://github.com/pulumi/pulumi-kubernetes/blob/4b01b5114df3045cecefd2ff3e2f2ed64430e3dd/sdk/nodejs/yaml/yaml.ts#L2214 for (const key in obj) { delete obj[key]; } Object.assign(obj, { kind: 'List', apiVersion: 'v1', metadata: {}, items: [], }); return null; } return; }; }
This used to work when i first wrote it because pulumi handled the v1/List type: see the code
But now this special handling for "list" is gone: see the code
I think this is a regression.
The text was updated successfully, but these errors were encountered:
Sorry about that. I'll get that fixed shortly.
Sorry, something went wrong.
lblackstone
Successfully merging a pull request may close this issue.
I've been using the following helm chart transformation for removing helm hooks:
This used to work when i first wrote it because pulumi handled the v1/List type: see the code
But now this special handling for "list" is gone: see the code
I think this is a regression.
The text was updated successfully, but these errors were encountered: