Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Helm chart resourcePrefix sometimes unused. #976

Closed
timmyers opened this issue Feb 3, 2020 · 0 comments · Fixed by #977
Closed

Helm chart resourcePrefix sometimes unused. #976

timmyers opened this issue Feb 3, 2020 · 0 comments · Fixed by #977
Assignees
@lblackstone
Labels
kind/bug Some behavior is incorrect or out of spec
Milestone
0.31

Comments

@timmyers
Copy link

timmyers commented Feb 3, 2020

Problem description

Sometimes when instantiating a new k8s.helm.v2.Chart, the resourcePrefix parameter is unused.

It seems it may be due to a bug on this line https://github.com/pulumi/pulumi-kubernetes/blob/master/sdk/nodejs/yaml/yaml.ts#L186, where the parameter is not passed through.
@lblackstone lblackstone self-assigned this Feb 4, 2020
@lblackstone lblackstone added the kind/bug Some behavior is incorrect or out of spec label Feb 4, 2020
@lblackstone lblackstone added this to the 0.31 milestone Feb 4, 2020
@lblackstone lblackstone mentioned this issue Feb 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lblackstone lblackstone

Labels
kind/bug Some behavior is incorrect or out of spec
Projects
None yet
Milestone
0.31
Development

Successfully merging a pull request may close this issue.

Use resourcePrefix on all code paths pulumi/pulumi-kubernetes
2 participants
@lblackstone @timmyers