Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove doubled 'shell quoting' for path #846

Closed
wants to merge 2 commits into from
Closed

Remove doubled 'shell quoting' for path #846

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71676d5
Remove duplicated 'shell quoting' for path
MatheusMiranda Oct 11, 2019
eecebd5
Update CHANGELOG
MatheusMiranda Oct 15, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
- v1.15.x
- v1.14.x

### Improvements

- Fix a bug that causes helm crash when referencing 'scoped packages' that start with '@'. (https://github.com/pulumi/pulumi-kubernetes/pull/846)

## 1.2.1 (October 10, 2019)

### Supported Kubernetes versions
Expand Down
2 changes: 1 addition & 1 deletion sdk/nodejs/helm/v2/helm.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ export class Chart extends yaml.CollectionComponentResource {
nodepath.join(chartDir.name, fetchedChartName, "values.yaml")
);
} else {
chart = path.quotePath(cfg.path);
chart = cfg.path;
defaultValues = path.quotePath(nodepath.join(chart, "values.yaml"));
}

Expand Down