Implement basic provider upgrade testing #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Does the PR have any schema changes?Looking good! No breaking changes found. |
|
This looks great! A nit: I'd love to see some description in the PR that would outline the change. |
aq17
approved these changes
Mar 14, 2023
Co-authored-by: Ian Wahbe <ian@wahbe.com>
Does the PR have any schema changes?Looking good! No breaking changes found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #175
Detect unexpected replace plans to prevent issues such as #173
See pulumi/pulumi-random#263 for prior art.
There is a lot of helper code temporarily included here (and also in pulumi-random) because we're out of time to properly figure out pulumi/pulumi#12125 - ideally the upgrade-style testing would be an easy to use feature of ProgramTest or similar framework and not require any helper code in providers.