Add a new tree-view form for the progress view. #1260
Conversation
pkg/backend/local/progress.go
Outdated
| @@ -82,6 +83,10 @@ type ProgressDisplay struct { | |||
| // Any system events we've received. They will be printed at the bottom of all the status rows | |||
| systemEventPayloads []engine.StdoutEventPayload | |||
|
|
|||
| // Used to record the order that rows are created in. That way, when we present in a tree, we | |||
| // can keep things ordered so they will not jump around. | |||
| displayTime int | |||
There was a problem hiding this comment.
FWIW, I think the Time suffix here is confusing. I would have expected this was going to a timestamp or something, but it looks like it's just a counter or row index?
There was a problem hiding this comment.
Yeah.. Do you have a better name? It's more a way to just know the display ordering. Perhaps displayOrderIndex?
There was a problem hiding this comment.
displayOrderIndex sounds great!
pkg/diag/colors/diag.go
Outdated
| @@ -81,15 +82,17 @@ func TrimColorizedString(v string, maxLength int) string { | |||
| contract.Assertf(!tagRegexp.MatchString(textOrTag), "Got a tag when we did not expect it") | |||
|
|
|||
| text := textOrTag | |||
| if currentLength+len(text) > maxLength { | |||
| textLen := utf8.RuneCountInString(text) | |||
There was a problem hiding this comment.
I suspect the interaction between counting runes but trimming on byte boundaries is going to lead to wackiness in some cases. Is there a reason we moved to utf8.RuneCountInString?
There was a problem hiding this comment.
Yes. certain characters like the tree-characters are 3 len long, but only one rune. You are correct though, the trimming based on length is totally bogus, i missed that, thanks!
|
This looks awesome! @CyrusNajmabadi Do you mind adding a line of descriptive text to the PR, to make changelog generation easier? |
Updated the pulumi console to print out the tree-structure of a program's resources when in a tty session.
The tree-structure updates live, but doesn't come across as distracting or hard to understand.
Looks like this: