Fix panic when looking up home #15160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changelog[uncommitted] (2024-01-17)Bug Fixes
|
tgummerer
approved these changes
Jan 17, 2024
6 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
### Features - [sdk/go] Add WithValue to pulumi.Context [#15149](#15149) ### Bug Fixes - [cli] Fix a panic when user's home directory could not be looked up. [#15160](#15160) - [cli/display] Fix JSON/YAML value diff displays. - [sdk/go] Update github.com/cloudflare/circl to v1.3.7. [#15151](#15151) - [cli/import] --import-file now omits empty resource lists. [#15132](#15132) - [sdk/python] Allow remote components to use output property called id ### Miscellaneous - [sdkgen] Emit a warning when using id or urn as resource outputs [#15060](#15060)
Merged
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 18, 2024
### Features - [sdk/go] Add WithValue to pulumi.Context [#15149](#15149) ### Bug Fixes - [cli] Fix a panic when user's home directory could not be looked up. [#15160](#15160) - [cli/display] Fix JSON/YAML value diff displays. [#15171](#15171) - [sdk/go] Update github.com/cloudflare/circl to v1.3.7. [#15151](#15151) - [cli/import] --import-file now omits empty resource lists. [#15132](#15132) - [sdk/python] Allow remote components to use output property called id [#15115](#15115) ### Miscellaneous - [sdkgen] Emit a warning when using id or urn as resource outputs [#15060](#15060)
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 9, 2024
<!--- Thanks so much for your contribution! If this is your first time contributing, please ensure that you have read the [CONTRIBUTING](https://github.com/pulumi/pulumi/blob/master/CONTRIBUTING.md) documentation. --> # Description #15160 tries to fix #15159 by checking that user is nil or user.HomeDir is nil. Given github.com/tweekmonster/luser embeds the builtin Golang User type as pointer, it still possible that user.User is nil and calling user.HomeDir causes a nil pointer access. this PR checks the embedded pointer explicitly Fixes #15159 ## Checklist - [x] I have run `make tidy` to update any new dependencies - [x] I have run `make lint` to verify my code passes the lint check - [ ] I have formatted my code using `gofumpt` <!--- Please provide details if the checkbox below is to be left unchecked. --> - [ ] I have added tests that prove my fix is effective or that my feature works <!--- User-facing changes require a CHANGELOG entry. --> - [x] I have run `make changelog` and committed the `changelog/pending/<file>` documenting my change <!-- If the change(s) in this PR is a modification of an existing call to the Pulumi Cloud, then the service should honor older versions of the CLI where this change would not exist. You must then bump the API version in /pkg/backend/httpstate/client/api.go, as well as add it to the service. --> - [ ] Yes, there are changes in this PR that warrants bumping the Pulumi Cloud API version <!-- @pulumi employees: If yes, you must submit corresponding changes in the service repo. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #15159.
user.Current()can potentially return nil in cases where the user lookup fails, further there's a chance thatHomeDirmight be empty even if a user is found. This makes both of these cases an error, preventing a panic in the former and preventing trying to use "/.pulumi/" in the later.Checklist
make tidyto update any new dependenciesmake lintto verify my code passes the lint checkgofumptmake changelogand committed thechangelog/pending/<file>documenting my change