[automation/nodejs] - Implement min version checking #6580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 19, 2021
komalali
force-pushed
the
komalali/nodejs-min-version
branch
from
8643756
to
59f3bc4
Compare
komalali
force-pushed
the
komalali/nodejs-min-version
branch
from
f5d8937
to
0faad46
Compare
komalali
force-pushed
the
komalali/nodejs-min-version
branch
from
0faad46
to
57a895e
Compare
komalali
force-pushed
the
komalali/nodejs-min-version
branch
from
57a895e
to
09b7e1b
Compare
This was referenced Mar 20, 2021
lblackstone
reviewed
Mar 22, 2021
EvanBoyle
approved these changes
Mar 22, 2021
komalali
force-pushed
the
komalali/nodejs-min-version
branch
from
f05c0b7
to
1d4a39d
Compare
komalali
force-pushed
the
komalali/nodejs-min-version
branch
from
1d4a39d
to
eac890b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LocalWorkspace.pulumiVersionproperty that returns the underlying Pulumi CLI version.LocalWorkspaceconstructor checks that thepulumiVersion>= the minimum version set inminimumVersion.tsand returns an error to update the CLI if the check fails.Nodejs part of #6348 and #6419
Also see: #6577 for Go