New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[automation/dotnet] - Implement min version checking #6590
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 20, 2021
komalali
force-pushed
the
komalali/csharp-min-version
branch
from
March 20, 2021 21:38
300cfad
to
a3df334
Compare
komalali
commented
Mar 20, 2021
orionstudt
reviewed
Mar 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some remarks, otherwise looks good :)
komalali
force-pushed
the
komalali/csharp-min-version
branch
from
March 23, 2021 06:21
5a57425
to
a7ed6a5
Compare
komalali
force-pushed
the
komalali/csharp-min-version
branch
from
March 23, 2021 20:40
a7ed6a5
to
0d7c14f
Compare
This was
linked to
issues
Mar 23, 2021
mikhailshilkov
approved these changes
Mar 24, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
komalali
force-pushed
the
komalali/csharp-min-version
branch
from
March 24, 2021 16:24
dd1fab2
to
c4654d4
Compare
komalali
force-pushed
the
komalali/csharp-min-version
branch
from
March 24, 2021 16:34
c4654d4
to
5a72578
Compare
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
LocalWorkspace.PulumiVersion
field that returns the underlying Pulumi CLI version.LocalWorkspace
constructor checks that thePulumiVersion
>=LocalWorkspace._minimumVersion
and raises an exception to update the CLI if the check fails.Please let me know if there's a more idiomatic way to do this!
C# part of #6348 and #6419
Also see: #6577 for Go, #6580 for nodejs and #6589 for python