Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation/dotnet] - Implement min version checking #6590

Merged
merged 7 commits into from Mar 24, 2021

Conversation

komalali
Copy link
Member

@komalali komalali commented Mar 20, 2021

Changes

  • Added a LocalWorkspace.PulumiVersion field that returns the underlying Pulumi CLI version.
  • LocalWorkspace constructor checks that the PulumiVersion >= LocalWorkspace._minimumVersion and raises an exception to update the CLI if the check fails.

Please let me know if there's a more idiomatic way to do this!

C# part of #6348 and #6419

Also see: #6577 for Go, #6580 for nodejs and #6589 for python

@komalali komalali marked this pull request as ready for review March 20, 2021 22:24
Copy link
Contributor

@orionstudt orionstudt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some remarks, otherwise looks good :)

sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/PublicAPI.Unshipped.txt Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/PublicAPI.Unshipped.txt Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
@komalali komalali force-pushed the komalali/csharp-min-version branch from 5a57425 to a7ed6a5 Compare March 23, 2021 06:21
Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

sdk/dotnet/Pulumi.Automation/LocalWorkspace.cs Outdated Show resolved Hide resolved
@komalali komalali force-pushed the komalali/csharp-min-version branch from dd1fab2 to c4654d4 Compare March 24, 2021 16:24
@komalali komalali force-pushed the komalali/csharp-min-version branch from c4654d4 to 5a72578 Compare March 24, 2021 16:34
@komalali komalali merged commit 19c0553 into master Mar 24, 2021
@komalali komalali deleted the komalali/csharp-min-version branch March 24, 2021 17:43
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants