Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[automation/python] - Implement min version checking #6589

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

komalali
Copy link
Member

Changes

  • Added a LocalWorkspace.pulumi_version attribute that returns the underlying Pulumi CLI version.
  • LocalWorkspace constructor checks that the pulumi_version >= the minimum version set in _minimum_version.py and raises an exception to update the CLI if the check fails.

Python part of #6348 and #6419

Also see: #6577 for Go and #6580 for nodejs

@komalali komalali force-pushed the komalali/python-min-version branch from 25a6925 to 2b6e338 Compare March 23, 2021 04:43
@komalali komalali force-pushed the komalali/python-min-version branch from 2b6e338 to a79f0ac Compare March 23, 2021 06:07
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@komalali komalali merged commit b187ce1 into master Mar 23, 2021
@komalali komalali deleted the komalali/python-min-version branch March 23, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants