Skip updates, {vm,kubernetes}-azure-yaml #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnunciato
force-pushed
the
cnunciato/previews-only
branch
from
5e066a1
to
43fa275
Compare
cnunciato
commented
Jan 12, 2023
| @@ -125,14 +125,11 @@ jobs: | |||
| env: | |||
| PULUMI_PYTHON_CMD: python | |||
| TESTPARALLELISM: 3 | |||
| SKIPPED_TESTS: "alicloud,digitalocean,kubernetes,openstack,equinix-metal,civo,aiven,auth0,github,oci,java-jbang,java-gradle,azuredevops,container" | |||
There was a problem hiding this comment.
Not sure why these are overridden -- I believe these steps should inherit the values set on line 22.
cnunciato
force-pushed
the
cnunciato/previews-only
branch
2 times, most recently
from
00b67ce
to
0485426
Compare
cnunciato
changed the title
cnunciato
force-pushed
the
cnunciato/previews-only
branch
2 times, most recently
from
3e3e804
to
a4218ce
Compare
cnunciato
force-pushed
the
cnunciato/previews-only
branch
from
a4218ce
to
1371ed5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a follow-up to https://github.com/pulumi/devrel-team/issues/464, this change skips running full updates for all templates, relying instead on successful previews, and adds
vm-azure-yamlandkubernetes-azure-yamlto the list of skipped tests.Doesn't represent the ideal state for sure, but given the state we're in now, we think this is an acceptable trade-off to get back to reliably passing while we explore alternative ways to run full deployments for some or all templates.
Note that this change also skips testing
github-go(temporarily) due to #481. I'll remove it from the list once that issue's fixed.Fixes https://github.com/pulumi/devrel-team/issues/487.