Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix go.mod templating script, update go.mods #515

Merged
merged 1 commit into from
Jan 19, 2023
Merged

Fix go.mod templating script, update go.mods #515

merged 1 commit into from
Jan 19, 2023

Conversation

cnunciato
Copy link
Member

@cnunciato cnunciato commented Jan 19, 2023 •
edited
Loading

This change makes a few updates:

  • Bumps the Go versions in the template files that we use to regenerate go.mod files (e.g., in response to a CLI release) to 1.18 (to align with the templates themselves)
  • Alphabetizes the names of the providers for which we do this
  • Adjusts the commit message and title of the PRs we generate from these events to make it clearer what these PRs actually are and where they come from
  • Re-runs the script to get the go.mods updated

Replaces #512.

@cnunciato cnunciato requested a review from a team January 19, 2023 01:51
@cnunciato cnunciato mentioned this pull request Jan 19, 2023
Closed
@cnunciato cnunciato changed the title Fix go.mod templating script Fix go.mod templating script, update go.mods Jan 19, 2023
scottslowe
scottslowe approved these changes Jan 19, 2023
View reviewed changes
Copy link
Contributor

@scottslowe scottslowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@cnunciato cnunciato merged commit 14ccb5b into master Jan 19, 2023
@cnunciato cnunciato deleted the cnunciato/regenerate-fix branch January 19, 2023 14:37
@scottslowe scottslowe mentioned this pull request Jan 19, 2023
Closed
dirien pushed a commit to dirien/templates that referenced this pull request Mar 29, 2023
@cnunciato @dirien
Fix go.mod templating script (pulumi#515)
d0c6a88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottslowe scottslowe scottslowe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cnunciato @scottslowe