-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add #flush
and #sync
methods to Puma::NullIO
#2553
Conversation
The "windows-2019 2.7 no SSL" CI failure looks unrelated, AFAICT. |
@nateberkopec Thanks for the quick review and merge! Do you think it would be useful to add more methods to |
@olivierbellone I think so! I did #2520 after I found out |
Seems like we'll need it eventually so that's fine by me @olivierbellone |
Description
Add
#flush
and#sync
methods toPuma::NullIO
.This fixes an issue if you're using
Events.null
, e.g.:Without this patch, this would fail with:
Your checklist for this pull request
[changelog skip]
or[ci skip]
to the pull request title.[ci skip]
to the title of the PR.#issue
" to the PR description or my commit messages.