Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash if the secret is "my dog has fleas" #1387

Closed
strugee opened this issue Jul 14, 2017 · 2 comments
Closed

Crash if the secret is "my dog has fleas" #1387

strugee opened this issue Jul 14, 2017 · 2 comments
Labels
security semver-major
Milestone
Future

Comments

@strugee
Copy link
Member

strugee commented Jul 14, 2017

Or maybe fail? I wonder what will break if the secret's changed.
@strugee strugee added this to the Near future milestone Jul 14, 2017
strugee added a commit that referenced this issue Aug 21, 2017
@strugee
Warn on insecure config.secret values
7ce80cb 
Ref #1387
@strugee
Copy link
Member Author

strugee commented Aug 21, 2017

Labeling this semver-major and moving to Future to track making this a fatal error.

@strugee strugee modified the milestones: Future, Near future Aug 21, 2017
@strugee strugee changed the title Warn if the secret is "my dog has fleas" Crash if the secret is "my dog has fleas" Apr 4, 2018
@strugee
Copy link
Member Author

strugee commented Jun 20, 2018

Looks like somehow, nothing breaks?? I think it might be because we do everything in the web UI through OAuth tokens... anyway. Looks like this is okay to make a fatal error.

strugee added a commit that referenced this issue Oct 5, 2018
@strugee
Add a secret to app-bounce-test-as-root.js
ae10992 
Fixes a crash due to #1387.
strugee added a commit that referenced this issue Oct 5, 2018
@strugee
Add a secret to app-https-test-as-root.js
97a3605 
Fixes a crash due to #1387.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
security semver-major
Projects
None yet
Milestone
Future
Development

No branches or pull requests
1 participant
@strugee