Reduce .jade.js bloat #1457
Merged
Reduce .jade.js bloat #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
strugee
force-pushed
the
reduce-jade-js-bloat
branch
from
b177510
to
6efcfbe
Compare
strugee
force-pushed
the
reduce-jade-js-bloat
branch
from
6efcfbe
to
d0c6f95
Compare
strugee
force-pushed
the
reduce-jade-js-bloat
branch
from
3d3d280
to
c0c3b1a
Compare
strugee
force-pushed
the
reduce-jade-js-bloat
branch
from
c0c3b1a
to
739fdfb
Compare
strugee
force-pushed
the
reduce-jade-js-bloat
branch
from
62130c6
to
a56ac52
Compare
|
IIRC when I worked on this I was pretty disappointed with the results (they didn't improve a lot) but I might as well merge this since it's been sitting open forever for no reason. Self-assigning to rebase and merge. |
strugee
force-pushed
the
reduce-jade-js-bloat
branch
from
a56ac52
to
c7fdf3e
Compare
AFAICT this used to load dependency templates, but this is irrelevant now that we use Jade's `include` which inlines dependencies directly. So nuke this property from orbit. (Honestly, there didn't seem to be anything referencing it anyway.)
These were picked up by a script when I originally created all the `-client` files, but it's safe to get rid of these particular `-client` splits because all these templates will only ever be rendered by the server. Because of the same reason, we move them to `lib/` so they don't get rendered into client files.
strugee
force-pushed
the
reduce-jade-js-bloat
branch
from
1b9895f
to
45a8e0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a crack at only building
.jade.jsfiles when we need them. This means that package tarballs distributed on npm will be smaller, which is nice.