Make add_pupil_ellipse a class to make it picklable #1376
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting a background process on Windows, the os creates an actual new process (instead of just a new fork). Therefore, everything needs to be copied / pickled. The eye video exporter formerly used a function factory to create a function that renders pupil positions, but the returned function would not be pickleable. This is now fixed by replacing the old functionality with a callable class that can get copied to the background process.