Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settable Pupil Remote port via argument parsing #1384

Merged
merged 15 commits into from
Nov 19, 2018
Merged

Settable Pupil Remote port via argument parsing #1384

merged 15 commits into from
Nov 19, 2018

Conversation

papr
Copy link
Contributor

@papr papr commented Nov 12, 2018

This PR implements #1315 by fixing #1377

Todos:

  • Test on Linux/Mac when running from bundle
  • Test on Windows when running from source and from bundle

Help Texts

> python main.py -h
usage: main.py [-h] [--debug] [--profile] {capture,service,player} ...

optional arguments:
  -h, --help            show this help message and exit
  --debug               display debug log messages
  --profile             profile the application's CPU time

Applications:
  Select which application you want to run, by default `capture`

  {capture,service,player}
    capture             Real-time processing and recording
    service             VR/AR interface
    player              Process, visualize, and export recordings
> python main.py capture -h
usage: main.py capture [-h] [-P PORT]

optional arguments:
  -h, --help            show this help message and exit
  -P PORT, --port PORT  Pupil Remote port
> python main.py service -h
usage: main.py service [-h] [-P PORT]

optional arguments:
  -h, --help            show this help message and exit
  -P PORT, --port PORT  Pupil Remote port
>  python main.py player -h
usage: main.py player [-h] [recording]

positional arguments:
  recording   path to recording

optional arguments:
  -h, --help  show this help message and exit

@papr papr added this to the v1.10 milestone Nov 12, 2018
pupil_src/launchables/args.py Outdated Show resolved Hide resolved
Copy link
Contributor

@ckbaumann ckbaumann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice ✨ code!

pupil_src/launchables/args.py Outdated Show resolved Hide resolved
pupil_src/launchables/service.py Outdated Show resolved Hide resolved
pupil_src/launchables/service.py Outdated Show resolved Hide resolved
pupil_src/launchables/args.py Outdated Show resolved Hide resolved
pupil_src/launchables/args.py Outdated Show resolved Hide resolved
pupil_src/main.py Outdated Show resolved Hide resolved
@papr papr merged commit 1fdc80a into pupil-labs:master Nov 19, 2018
@willpatera
Copy link
Member

@papr I tested the CL args on Windows bundle with Capture and Player (not service yet). All seems to be working as designed. 👍

@papr papr deleted the 1377_argparse branch March 12, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants