Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract pupil_detectors into a separate repo #1642

Merged
merged 49 commits into from Dec 12, 2019
Merged

Extract pupil_detectors into a separate repo #1642

merged 49 commits into from Dec 12, 2019

Commits on Sep 17, 2019

  1. Extract pupil_detectors into a separate repo 

    https://github.com/pupil-labs/pupil-detectors
    @romanroibu
    romanroibu committed Sep 17, 2019
    Copy the full SHA
    c0867e0 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2019

  1. Update eye.py to use the new Detector_2D_Plugin class

    @romanroibu
    romanroibu committed Sep 19, 2019
    Copy the full SHA
    191e8d6 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2019

  1. Add PupilDetectorManager to eye.py 

    Instances of this class hide all knowledge regarding pupil_detectors and expose an interface for the various UI lifecycle events and UI components. It also lazily imports symbols from pupil_detectors.plugins on init.
    @romanroibu
    romanroibu committed Sep 20, 2019
    Copy the full SHA
    6388473 View commit details
    Browse the repository at this point in the history

  2. Use PupilDetectorManager instance in eye.py

    @romanroibu
    romanroibu committed Sep 20, 2019
    Copy the full SHA
    37d7dab View commit details
    Browse the repository at this point in the history

Commits on Sep 23, 2019

  1. Remove debug print statement

    @romanroibu
    romanroibu committed Sep 23, 2019
    Copy the full SHA
    5e17b59 View commit details
    Browse the repository at this point in the history

  2. Fix PupilDetectorManager.activate_detector_by_name plugin_name argument

    @romanroibu
    romanroibu committed Sep 23, 2019
    Copy the full SHA
    9dca2e4 View commit details
    Browse the repository at this point in the history

  3. Update eye.py to use the latest Plugin API for PupilDetectorPlugin

    @romanroibu
    romanroibu committed Sep 23, 2019
    Copy the full SHA
    7c050ce View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2019

  1. Merge branch 'master' into extract-pupil-detectors

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    2b40880 View commit details
    Browse the repository at this point in the history

  2. Move Pupil Manager into separate file

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    cc1b23b View commit details
    Browse the repository at this point in the history

  3. Move plugin code from detectors repo back to pupil

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    412d114 View commit details
    Browse the repository at this point in the history

  4. Load pupil detector plugins and manager as plugins

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    23458dc View commit details
    Browse the repository at this point in the history

  5. Move detector/manager specific code to according classes

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    dfda577 View commit details
    Browse the repository at this point in the history

  6. eye.py: Use plugin api properly

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    9aa2681 View commit details
    Browse the repository at this point in the history

  7. Roi: Remove unnecessary view setter

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    c9b9f30 View commit details
    Browse the repository at this point in the history

  8. Use g_pool.flip if available in base source

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    3ea6bed View commit details
    Browse the repository at this point in the history

  9. Use correct detector base class

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    1098ca4 View commit details
    Browse the repository at this point in the history

  10. Detector plugins + manager: Fix variable names

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    81aedf1 View commit details
    Browse the repository at this point in the history

  11. Set DetectorPlugin.detect(frame) as interface

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    aab3555 View commit details
    Browse the repository at this point in the history

  12. Sort imports

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    1d3dad6 View commit details
    Browse the repository at this point in the history

  13. Detector 3d plugin: Use correct api

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    a1eaa2f View commit details
    Browse the repository at this point in the history

  14. Apply black

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    3f868fb View commit details
    Browse the repository at this point in the history

  15. Detector 2d plugin: Set correct label/identifier

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    fd25f54 View commit details
    Browse the repository at this point in the history

  16. PupilDetectorPlugin: Document label/identifier

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    00aae53 View commit details
    Browse the repository at this point in the history

  17. Detector 3d plugin: Fix missing key and use coorect method call

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    7df0be4 View commit details
    Browse the repository at this point in the history

  18. Fix Detector 2d Plugin

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    3d85dec View commit details
    Browse the repository at this point in the history

  19. Fix Detector Dummy Plugin

    @papr
    papr committed Oct 15, 2019
    Copy the full SHA
    5629e6f View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Fix roi+algorithm view

    @papr
    papr committed Oct 16, 2019
    Copy the full SHA
    8cb49fd View commit details
    Browse the repository at this point in the history

  2. Move pupil+eyeball outline drawing into visualizer2d and call from de… 

    …tector plugin
    @papr
    papr committed Oct 16, 2019
    Copy the full SHA
    fa4552b View commit details
    Browse the repository at this point in the history

  3. Fix crash when selecting 2D detector

    @pfaion
    pfaion committed Oct 16, 2019
    Copy the full SHA
    9738c0f View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2019

  1. Fix incorrect parameters for changing properties via network

    @pfaion
    pfaion committed Oct 17, 2019
    Copy the full SHA
    da283c7 View commit details
    Browse the repository at this point in the history

  2. Add early-exit to handle_set_property_notification 

    "Flat is better than nested."
    @pfaion
    pfaion committed Oct 17, 2019
    Copy the full SHA
    5dfd6b4 View commit details
    Browse the repository at this point in the history

  3. Add better error handling for set_property for roi

    @pfaion
    pfaion committed Oct 17, 2019
    Copy the full SHA
    a5e5d79 View commit details
    Browse the repository at this point in the history

  4. Fix broken roi update logic when setting via network 

    Roi.set expects the arguments in a different order, resulting in a wrong assignment of values that sometimes led to crashes in opencv on c++ side.
    @pfaion
    pfaion committed Oct 17, 2019
    Copy the full SHA
    5a0040b View commit details
    Browse the repository at this point in the history

  5. Improve formatting

    @pfaion
    pfaion committed Oct 17, 2019
    Copy the full SHA
    edd7d45 View commit details
    Browse the repository at this point in the history

  6. Handle 'nan' values in pupil visualizations better

    @pfaion
    pfaion committed Oct 17, 2019
    Copy the full SHA
    03642eb View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2019

  1. Remoe singleeyefitter dependency from calibration module

    @papr
    papr committed Oct 21, 2019
    Copy the full SHA
    f9e0cc9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'extract-pupil-detectors' of github.com:romanroibu/pupil… 

    … into extract-pupil-detectors
    @papr
    papr committed Oct 21, 2019
    Copy the full SHA
    2fd5a35 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. Remove dead UI code

    @pfaion
    pfaion committed Nov 4, 2019
    Copy the full SHA
    31ba31b View commit details
    Browse the repository at this point in the history

  2. Remove dead UI code

    @pfaion
    pfaion committed Nov 4, 2019
    Copy the full SHA
    0f5b454 View commit details
    Browse the repository at this point in the history

  3. Replace detector API

    @pfaion
    pfaion committed Nov 4, 2019
    Copy the full SHA
    f7fa3eb View commit details
    Browse the repository at this point in the history

  4. Hookup detector UI via new PropertyProxy

    @pfaion
    pfaion committed Nov 4, 2019
    Copy the full SHA
    8cb24d1 View commit details
    Browse the repository at this point in the history

  5. Remove unused method

    @pfaion
    pfaion committed Nov 4, 2019
    Copy the full SHA
    3d947d7 View commit details
    Browse the repository at this point in the history

  6. Fix broken on_resolution_change

    @pfaion
    pfaion committed Nov 4, 2019
    Copy the full SHA
    5e46637 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Move imports to top of the file

    @pfaion
    pfaion committed Dec 9, 2019
    Copy the full SHA
    24b263b View commit details
    Browse the repository at this point in the history

  2. Improve variable names

    @pfaion
    pfaion committed Dec 9, 2019
    Copy the full SHA
    5d3718c View commit details
    Browse the repository at this point in the history

  3. Add review suggestion for improved readability

    @pfaion
    pfaion committed Dec 9, 2019
    Copy the full SHA
    768ab4c View commit details
    Browse the repository at this point in the history

  4. Merge branch 'develop' into extract-pupil-detectors 

    # Conflicts:
#	pupil_src/launchables/eye.py
#	pupil_src/shared_modules/pupil_detectors/detector_2d.pyx
#	pupil_src/tests/pupil_detectors/test_distance_point_line.py
#	pupil_src/tests/pupil_detectors/test_solve_npn.py
    @pfaion
    pfaion committed Dec 9, 2019
    Copy the full SHA
    f56efdc View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Merge branch 'develop' into extract-pupil-detectors

    @papr
    papr committed Dec 11, 2019
    Copy the full SHA
    edc943b View commit details
    Browse the repository at this point in the history

  2. Don't build detectors anymore

    @papr
    papr committed Dec 11, 2019
    Copy the full SHA
    759bc3e View commit details
    Browse the repository at this point in the history