Improve Offline Pupil Detection data storage during detection #1899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rdered pupil data
romanroibu
approved these changes
Jun 2, 2020
pfaion
reviewed
Jun 3, 2020
|
@papr Did you find a reliable way of reproducing the crash with |
|
The issue was caused when the Bisector was initialized with data (which was transformed into a ndarray) and then data was inserted during the pupil redetection. I think this was the case when restoring cached offline pupil data and then hitting recalculate. |
pfaion
reviewed
Jun 3, 2020
papr
commented
Jun 3, 2020
pfaion
approved these changes
Jun 3, 2020
pfaion
approved these changes
Jun 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using
Mutable_Bisectors (which usenump.insert), use a timestamp->datum mapping. This has the advantage of being faster and avoids duplicated entries when restarting the detection while there is an existing detection running.This PR also correctly announces cached pupil data as "existing" instead of "new". This avoids recalculating e.g. offline gaze mappings on restoring a session.