Remove 3D pupil detector #2011
Merged
Remove 3D pupil detector #2011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pfaion
reviewed
Sep 14, 2020
romanroibu
force-pushed
the
remove-3d-pupil-detector
branch
from
10912d4
to
bc69be1
Compare
papr
reviewed
Nov 16, 2020
papr
reviewed
Nov 25, 2020
pupil_src/shared_modules/pupil_detector_plugins/detector_base_plugin.py
Outdated
Show resolved
Hide resolved
papr
reviewed
Nov 25, 2020
There was a problem hiding this comment.
Meeting notes
- every detector publishes their own property broadcast
- differentiate between target process and target detector
- use class name to identify detector target
- process and detector targets are optional for requesting the current property values
- setting properties requires at least a detector target
- notifications emitted should include eye_id and detector class name in the subject as well as in the payload
pupil_src/shared_modules/pupil_detector_plugins/detector_base_plugin.py
Outdated
Show resolved
Hide resolved
pupil_src/shared_modules/pupil_detector_plugins/detector_base_plugin.py
Outdated
Show resolved
Hide resolved
papr
reviewed
Nov 30, 2020
pupil_src/shared_modules/pupil_detector_plugins/detector_base_plugin.py
Outdated
Show resolved
Hide resolved
pupil_src/shared_modules/pupil_detector_plugins/detector_base_plugin.py
Outdated
Show resolved
Hide resolved
papr
reviewed
Dec 1, 2020
papr
added
the
API changes
papr
approved these changes
Dec 2, 2020
Using pupil-detectors>=2.0.1 and higher, Ceres is no longer needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the default 3D pupil detector plugin from Pupil Core and introduces a simplified pupil detector network api.
ClickUp Task