Fix eye overlay plugin visualizing invalid data #2021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@romanroibu have you tested other eye related functionality, e.g. Offline pupil detection, eye export, etc |
pfaion
reviewed
Oct 2, 2020
papr
suggested changes
Oct 2, 2020
pupil_src/shared_modules/video_overlay/utils/image_manipulation.py
Outdated
Show resolved
Hide resolved
papr
approved these changes
Oct 6, 2020
|
Tested using the recording that caused the initial issue (eye overlay works, but without visualization, as expected) and a separate recording (eye overlay works with visualization, as expected.). |
papr
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues related to the eye overlay plugin that caused crashes when the confidence value was not valid (
infornan). Additionally, it fixes the way this plugin was searching for eye videos in the recordings and was causing it to mistakenly useeye1.instrinsicsas a video source.Click-Up Task